Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cartridges: init at 2.0.4 #234486

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented May 27, 2023

Description of changes

cartridges is a simple game launcher written in python using libadwaita. it supports managing games from platforms/programs such as steam, lutris, heroic, bottles, and itch.io

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@getchoo getchoo changed the title Add cartridges cartridges: init at 1.5.4 May 27, 2023
@getchoo getchoo mentioned this pull request May 27, 2023
31 tasks
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 27, 2023
@eyome eyome mentioned this pull request May 29, 2023
@getchoo getchoo force-pushed the add-cartridges branch 2 times, most recently from b7f95e6 to 13e1b1b Compare June 12, 2023 00:18
pkgs/applications/misc/cartridges/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/cartridges/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/cartridges/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/cartridges/default.nix Outdated Show resolved Hide resolved
@getchoo getchoo changed the title cartridges: init at 1.5.4 cartridges: init at 1.5.6 Jun 30, 2023
@getchoo getchoo requested a review from SuperSandro2000 June 30, 2023 18:03
pkgs/applications/misc/cartridges/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/cartridges/default.nix Outdated Show resolved Hide resolved
@getchoo getchoo requested a review from BenediktBroich July 6, 2023 17:46
@getchoo getchoo changed the title cartridges: init at 1.5.6 cartridges: init at 2.0.1 Jul 6, 2023
@BenediktBroich
Copy link
Contributor

@ofborg build cartridges

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 6, 2023
@mweinelt mweinelt removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 7, 2023
@getchoo getchoo changed the title cartridges: init at 2.0.1 cartridges: init at 2.0.4 Jul 9, 2023
@BenediktBroich
Copy link
Contributor

Result of nixpkgs-review pr 234486 run on x86_64-linux 1

1 package built:
  • cartridges

@SuperSandro2000 SuperSandro2000 merged commit 79f2bc3 into NixOS:master Jul 19, 2023
@getchoo getchoo deleted the add-cartridges branch July 19, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants