Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.libsixel: fix build on darwin #234739

Merged
merged 1 commit into from
May 29, 2023
Merged

python3Packages.libsixel: fix build on darwin #234739

merged 1 commit into from
May 29, 2023

Conversation

natsukium
Copy link
Member

Description of changes

ZHF: #230712
https://hydra.nixos.org/build/219853242

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 29, 2023
@natsukium natsukium added 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign backport release-23.05 labels May 29, 2023
@natsukium natsukium marked this pull request as draft May 29, 2023 05:45
@ofborg ofborg bot requested a review from rmcgibbo May 29, 2023 05:59
@natsukium natsukium force-pushed the python3Packages.libsixel/fix-darwin branch from 7e53477 to 21a36d6 Compare May 29, 2023 06:09
@natsukium natsukium marked this pull request as ready for review May 29, 2023 06:11
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels May 29, 2023
@wegank
Copy link
Member

wegank commented May 29, 2023

@ofborg build python3Packages.libsixel python3Packages.libsixel.passthru.tests

@wegank wegank merged commit 64619da into NixOS:master May 29, 2023
@github-actions github-actions bot mentioned this pull request May 29, 2023
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

@natsukium natsukium deleted the python3Packages.libsixel/fix-darwin branch May 29, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmcgibbo rmcgibbo Awaiting requested review from rmcgibbo

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natsukium @wegank