Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixVersions.nix_2_16: init at 2.16.0 #235221

Merged
merged 3 commits into from
Jun 1, 2023
Merged

nixVersions.nix_2_16: init at 2.16.0 #235221

merged 3 commits into from
Jun 1, 2023

Conversation

lovesegfault
Copy link
Member

Description of changes
  • nixVersions: use hash instead of sha256
  • nixVersions.nix_2_16: init at 2.16.0
  • nixVersions.unstable: 2.15 -> 2.16
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@lovesegfault
Copy link
Member Author

Result of nixpkgs-review pr 235221 run on x86_64-linux 1

7 packages built:
  • nix-init
  • nixVersions.nix_2_16
  • nixVersions.nix_2_16.debug
  • nixVersions.nix_2_16.dev
  • nixVersions.nix_2_16.doc
  • nixVersions.nix_2_16.man
  • nurl

@lovesegfault
Copy link
Member Author

Result of nixpkgs-review pr 235221 run on aarch64-darwin 1

6 packages built:
  • nix-init
  • nixVersions.nix_2_16
  • nixVersions.nix_2_16.dev
  • nixVersions.nix_2_16.doc
  • nixVersions.nix_2_16.man
  • nurl

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label May 31, 2023
@ofborg ofborg bot requested review from edolstra and Artturin May 31, 2023 16:37
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 31, 2023
drupol
drupol approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@lovesegfault lovesegfault merged commit bc4dc97 into NixOS:master Jun 1, 2023
@lovesegfault lovesegfault deleted the nix-2.16.0 branch June 1, 2023 14:48
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-2-16-released/28597/4

@infinisil infinisil mentioned this pull request Jun 1, 2023
Merged
12 tasks
@Kranzes Kranzes mentioned this pull request Jun 7, 2023
Merged
12 tasks
@lorenzleutgeb lorenzleutgeb mentioned this pull request Jun 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@zowoq zowoq zowoq approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@Artturin Artturin Awaiting requested review from Artturin

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lovesegfault @nixos-discourse @drupol @zowoq