Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cctools-port: fix build with clang 16 on x86_64-darwin #240654

Merged
merged 1 commit into from
Jul 4, 2023
Merged

cctools-port: fix build with clang 16 on x86_64-darwin #240654

merged 1 commit into from
Jul 4, 2023

Conversation

reckenrode
Copy link
Contributor

Description of changes

Clang 16 fails to build even with open_memstream disabled. Just use the memstream package to provide an implementation.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 30, 2023
@reckenrode reckenrode mentioned this pull request Jun 30, 2023
Closed
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild label Jun 30, 2023
@ofborg ofborg bot requested a review from matthewbauer June 30, 2023 05:46
@reckenrode
cctools-port: fix build with clang 16 on x86_64-darwin
cf77dee 
Clang 16 fails to build even with `open_memstream` disabled. Just use
the memstream package to provide an implementation.
@reckenrode reckenrode force-pushed the cctools-port-clang16 branch from fff9450 to cf77dee Compare June 30, 2023 21:13
@wegank
Copy link
Member

wegank commented Jul 3, 2023 •
edited
Loading

@ofborg build rustc

@reckenrode
Copy link
Contributor Author

It timed out building llvm. Is that expected?

@wegank
Copy link
Member

wegank commented Jul 4, 2023 •
edited
Loading

Yeah, that's normal. Built successfully on my machine.

@wegank wegank merged commit 297886f into NixOS:staging Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank wegank left review comments

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reckenrode @wegank