Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cockroachdb-bin: init at 23.1.7 #240683

Merged
merged 2 commits into from
Aug 2, 2023
Merged

cockroachdb-bin: init at 23.1.7 #240683

merged 2 commits into from
Aug 2, 2023

Conversation

neosimsim
Copy link
Contributor

@neosimsim neosimsim commented Jun 30, 2023 •
edited
Loading

As part of #152626 we figured that recent versions of cockroach became nearly impossible to build.
As solution I suggest we use the pre-build releases in FHS.

Unfortunately version 20.1.8 has not been released for aarch so we have to drop these supported platforms, for now.

However I tested the derivation with a few newer release and they all worked, so updating cockroach should become a lot easier in the future.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module

@neosimsim neosimsim mentioned this pull request Jun 30, 2023
Closed
13 tasks
@neosimsim
Copy link
Contributor Author

@ofborg build cockroachdb

@neosimsim
Copy link
Contributor Author

Is there a way to build unfree packages with ofborg?

@neosimsim neosimsim force-pushed the cockroachdb-use-pre-build-binaries branch 2 times, most recently from ef8e5c6 to 68aeeb2 Compare June 30, 2023 09:02
@neosimsim neosimsim force-pushed the cockroachdb-use-pre-build-binaries branch 3 times, most recently from 78c55a6 to e4795b8 Compare June 30, 2023 16:47
@ofborg ofborg bot requested review from thoughtpolice and rushmorem June 30, 2023 17:32
@neosimsim
Copy link
Contributor Author

I just realized that FHS is obviously not supported for darwin.

@neosimsim neosimsim force-pushed the cockroachdb-use-pre-build-binaries branch from e4795b8 to 8a10448 Compare July 3, 2023 12:15
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin ofborg-internal-error Ofborg encountered an error and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Jul 3, 2023
@ankhers
Copy link
Contributor

ankhers commented Jul 5, 2023

Should this be introduced as cockroachdb-bin instead?

@turion
Copy link
Contributor

turion commented Jul 6, 2023

Should this be introduced as cockroachdb-bin instead?

Yes, good point.

@ankhers
Copy link
Contributor

ankhers commented Aug 1, 2023

Is there any additional movement on this? I would like to get this working now that an upstream bug has been fixed that prevented me from using cockroach.

If the original author does not have time to get this working, I can throw something together that follows this approach.

@neosimsim neosimsim force-pushed the cockroachdb-use-pre-build-binaries branch from 8a10448 to 4bfa588 Compare August 1, 2023 17:54
@neosimsim
Copy link
Contributor Author

Sorry for the delay. I added the change as cockroachdb-bin keeping the original cockroach as is.

@wegank wegank changed the title cockroackdb: use pre-build binaries cockroachdb-bin: init at 20.1.8 Aug 1, 2023
@neosimsim neosimsim force-pushed the cockroachdb-use-pre-build-binaries branch 3 times, most recently from 8b1d60c to 5bd6027 Compare August 1, 2023 18:20
@neosimsim
Copy link
Contributor Author

I figured that since this is now introduced as cockroachdb-bin there is no reason to start with 20.1.8. I bumped the version to most recent one, 23.1.7,

@neosimsim neosimsim changed the title cockroachdb-bin: init at 20.1.8 cockroachdb-bin: init at 23.1.7 Aug 1, 2023
@neosimsim
cockroachdb-bin: init at 23.1.7
609ebca 
Add cockroachdb-bin using pre-build binaries, since building from
source seem impossible.
@neosimsim neosimsim force-pushed the cockroachdb-use-pre-build-binaries branch from 5bd6027 to 609ebca Compare August 1, 2023 18:42
@wegank wegank self-requested a review August 1, 2023 19:43
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 1, 2023
@ankhers
Copy link
Contributor

ankhers commented Aug 2, 2023

I was able to build this as well as run a single node cluster and initialize it. I was also able to connect to the web interface (localhost:8080) and click around a bit. I can't say that everything is working 100%, but the basics seem to be working.

ankhers
ankhers approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@ankhers ankhers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now.

I would like to see a generic builder that would allow us to support various versions of cockroach, but that is something we can add at a later point.

@wegank wegank merged commit fd49815 into NixOS:master Aug 2, 2023
8 checks passed
@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turion turion turion left review comments

@ankhers ankhers ankhers approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@rushmorem rushmorem Awaiting requested review from rushmorem

@wegank wegank Awaiting requested review from wegank

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neosimsim @ankhers @turion @wegank @cole-h