Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapGAppsHook4: fix gtk4 for the wrong system #242720

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Jul 10, 2023

gtk3(gtk4) is in depsTargetTargetPropagated while without splicing this gtk3(gtk4) will be for hostTarget
and when wrapGAppsHook4 is in nativeBuildInputs
packages in depsTargetTargetPropagated will be treated like buildInputs

fixes pkgsCross.aarch64-multiplatform.gnome.zenity

Closes #238440

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

gtk3(gtk4) is in depsTargetTargetPropagated while without splicing this
gtk3(gtk4) will be for hostTarget
and when wrapGAppsHook4 is in nativeBuildInputs
packages in depsTargetTargetPropagated will be treated like buildInputs

fixes pkgsCross.aarch64-multiplatform.gnome.zenity
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 10, 2023
@kirillrdy
Copy link
Member

kirillrdy commented Jul 11, 2023

it builds !

pr-242720/nixpkgs]$ nix-build -A pkgsCross.aarch64-multiplatform.gnome.zenity
/nix/store/lhg42m18ayql73lrwqfrwkjqqdcnckmh-zenity-aarch64-unknown-linux-gnu-3.99.0

@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

@avnik
Copy link
Contributor

avnik commented Jul 12, 2023

@Artturin Could you explain, how __splicedPackages works, please?

@Artturin
Copy link
Member Author

@avnik #204303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: zenity (cross-compilation to aarch64-linux)
3 participants