Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.slack-bolt: init at 1.18.0 #243593

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

samuela
Copy link
Member

@samuela samuela commented Jul 15, 2023

Description of changes

Package the slack-bolt project. Also required fixing slack-sdk's build.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

samuela added 3 commits July 15, 2023 00:50
`python3Packages.databases` is broken due to encode/databases#530. Luckily, it turns out that `databases` was not a necessary dependency anyways. See slackapi/python-slack-sdk#1388.
@samuela
Copy link
Member Author

samuela commented Jul 17, 2023

if no one objects I'll merge tomorrow?

@samuela samuela merged commit dfc26ed into NixOS:master Jul 21, 2023
@samuela samuela deleted the samuela/slack-bolt branch July 21, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant