Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests.haskell.upstreamStackHpackVersion: init #243798

Merged
merged 1 commit into from
Jul 16, 2023
Merged

tests.haskell.upstreamStackHpackVersion: init #243798

merged 1 commit into from
Jul 16, 2023

Conversation

cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Jul 16, 2023 •
edited
Loading

Description of changes

This PR adds a Nixpkgs test that confirms that the upstream stack release uses the same version of hpack as the stack in Nixpkgs.

Fixes #223390

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@cdepillabout
tests.haskell.upstreamStackHpackVersion: init
c78223a 
This tests that the upstream `stack` release uses the same version of
`hpack` as the `stack` in Nixpkgs.
@cdepillabout
Copy link
Member Author

cdepillabout commented Jul 16, 2023 •
edited
Loading

@sternenseemann This uses your idea of a FOD in order to download the upstream stack binary without requiring updating the hash on every stack release. Seems like it works pretty well.

@ofborg build tests.haskell.upstreamStackHpackVersion

@cdepillabout cdepillabout linked an issue Jul 16, 2023 that may be closed by this pull request
nixpkgs stack uses different hpack than upstream binary release #223390
Closed
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 16, 2023
@cdepillabout cdepillabout merged commit 5d1c9db into NixOS:haskell-updates Jul 16, 2023
@cdepillabout cdepillabout deleted the stack-version-check branch July 16, 2023 13:46
@cdepillabout cdepillabout mentioned this pull request Jul 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

@maralorn maralorn Awaiting requested review from maralorn

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixpkgs stack uses different hpack than upstream binary release
2 participants
@cdepillabout @sternenseemann