Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixVersions.nix_2_17: init at 2.17.0 #245279

Merged
merged 2 commits into from
Jul 26, 2023
Merged

nixVersions.nix_2_17: init at 2.17.0 #245279

merged 2 commits into from
Jul 26, 2023

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jul 25, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@lovesegfault
Copy link
Member

@zowoq we should also (finally) update the fallback paths

@lovesegfault
Copy link
Member

Is there a good reason we're letting stable point to an older release?

@zowoq
Copy link
Contributor Author

zowoq commented Jul 25, 2023

Is there a good reason we're letting stable point to an older release?

Probably not a good reason but the last couple of nix bumps have had issues so I'm happy just adding the new version and bumping unstable, I'll leave dealing with the stable bump for someone else.

we should also (finally) update the fallback paths

This is only if the stable version changes?

@NickCao NickCao merged commit 1b54673 into NixOS:master Jul 26, 2023
@zowoq zowoq deleted the nix217 branch July 27, 2023 00:23
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Backport failed for release-23.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-23.05
git worktree add -d .worktree/backport-245279-to-release-23.05 origin/release-23.05
cd .worktree/backport-245279-to-release-23.05
git checkout -b backport-245279-to-release-23.05
ancref=$(git merge-base 35f43f9532c4485661cb30737c8e721aa647e04e df4d4190de92f26d22bcc2a586d0e353bdbbf21b)
git cherry-pick -x $ancref..df4d4190de92f26d22bcc2a586d0e353bdbbf21b

@zowoq
Copy link
Contributor Author

zowoq commented Aug 6, 2023

nixVersions.stable bump: #247475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants