Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octave-kernel: fix broken logo path and modernize meta #245339

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

thomasjm
Copy link
Contributor

Description of changes

This kernel is currently broken due to a change in the path to the logo PNG upstream. This PR fixes it and also modernizes the meta field slightly.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 25, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2474

@Mindavi Mindavi merged commit f066c5e into NixOS:master Jul 27, 2023
@SuperSandro2000
Copy link
Member

This PR fixes it and also modernizes the meta field slightly.

This is nonsense, it does not matter if meta is using with lib or not and neither is more modern than the other.

@thomasjm
Copy link
Contributor Author

@SuperSandro2000 so I would have thought, but a previous reviewer felt strongly about it:

#244775 (comment)

@thomasjm thomasjm mentioned this pull request Jul 27, 2023
12 tasks
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jul 28, 2023

He is at least partly wrong about it. nil, probably the best lsp right now, can handle with lib properly in some cases already and I only expect it to become better over time. There is currently no tool I know which falls apart when with lib is used and honestly it would probably be pretty weak if it couldn't handle this.

The problems with with only starts to become a problem when you layer multiple with on the same level with similar package sets. So something like with pkgs; with qtPackages; with plasma5Packages; is definitely to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants