Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin-stdenv: revert NIX_CC_NO_RESPONSE_FILE logic #245640

Merged
merged 1 commit into from
Aug 1, 2023
Merged

darwin-stdenv: revert NIX_CC_NO_RESPONSE_FILE logic #245640

merged 1 commit into from
Aug 1, 2023

Conversation

reckenrode
Copy link
Contributor

Description of changes

To work around intermitent build failures with clang 16, the stdenv attempted to pass arguments on the command-line on newer versions of macOS. Unfortunately, the larger ARG_MAX is still not large enough to build qtwebengine. This commit reverts the NIX_CC_NO_RESPONSE_FILE logic in the stdenv. The changes to cc-wrapper in #245282 are needed for clang 16 to prevent the above-mentioned build failures.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@reckenrode
darwin-stdenv: revert NIX_CC_NO_RESPONSE_FILE logic
2e45100 
To work around intermitent build failures with clang 16, the stdenv
attempted to pass arguments on the command-line on newer versions of
macOS. Unfortunately, the larger `ARG_MAX` is still not large enough to
build qtwebengine. This commit reverts the `NIX_CC_NO_RESPONSE_FILE`
logic in the stdenv. The changes to cc-wrapper in NixOS#245282 are needed for
clang 16 to prevent the above-mentioned build failures.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 27, 2023
@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Jul 27, 2023
@reckenrode reckenrode mentioned this pull request Jul 26, 2023
Closed
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 27, 2023
@reckenrode reckenrode mentioned this pull request Jul 27, 2023
Merged
12 tasks
@wegank wegank merged commit e870890 into NixOS:staging Aug 1, 2023
@reckenrode reckenrode mentioned this pull request Aug 1, 2023
Merged
12 tasks
@wegank wegank mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: stdenv Standard environment 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reckenrode @wegank