Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdenv: add pkgsCross.powernv.linux_latest to tests.cross.sanity #245970

Closed
wants to merge 1 commit into from
Closed

stdenv: add pkgsCross.powernv.linux_latest to tests.cross.sanity #245970

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2023

Description of changes

This commit adds pkgsCross.powernv.linux_latest to tests.cross.sanity now that it builds again.

Targeting staging because this needs #245449.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Jul 28, 2023

@ofborg build pkgsCross.powernv.linux_latest

@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 28, 2023
@@ -133,6 +133,7 @@ let
pkgs.pkgsMusl.stdenv
pkgs.pkgsLLVM.stdenv
pkgs.pkgsStatic.bash
pkgs.pkgsCross.powernv.linux_latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the kernel is too heavy to be here because it takes a massive amount of memory to build, and the kernel is not really “cross sanity”

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: these expressions are not built automatically by anything, anywhere (not Hydra, not OfBorg). It's an (executable) list of reminders for people who are doing large refactorings, so they can easily check that they aren't breaking things they personally don't use often.

Shall I split sanity into sanity-small and sanity-full?

The kernel builds need to be in here somewhere. The kernel has totally bespoke and different build processes for different architectures (yuck, I know).

Copy link
Member

@Artturin Artturin Jul 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When imagining sanity one thinks of sane compilers or build environments

How about a separate list for the kernels? tests.cross.kernels

@ghost ghost requested a review from Artturin July 29, 2023 19:32
@ghost ghost marked this pull request as draft July 31, 2023 21:42
@ghost ghost closed this Jan 23, 2024
@ghost ghost deleted the pr/test/cross-sanity/kernels branch January 23, 2024 06:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant