caddy: 2.6.4 -> 2.7.3; nixosTests.caddy: remove etag subtest #247823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.7.0-2.7.2 have been skipped due to bugs in the release. https://github.com/caddyserver/caddy/releases/tag/v2.7.3 https://github.com/caddyserver/caddy/releases/tag/v2.7.2 https://github.com/caddyserver/caddy/releases/tag/v2.7.1 https://github.com/caddyserver/caddy/releases/tag/v2.7.0 diff: caddyserver/caddy@v2.6.4...v2.7.3
Caddy 2.7.x does no longer return etags for files with unix modtimes of 0 and 1. Files in /nix/store have a modtime of 1. This is something that has been specifically implemented for nix. For now, we decided to remove the test. But I might reimplement a similar etag subtest some time in the future.
github-actions
bot
added
the
6.topic: nixos
ofborg
bot
added
11.by: package-maintainer
|
Thanks for taking this over @emilylange :) I've been afk for a bit and hadn't been able to get to the changes in the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Supersedes #246859 due to inactivity.
2.7.0-2.7.2 have been skipped due to bugs in the release.
https://github.com/caddyserver/caddy/releases/tag/v2.7.3
https://github.com/caddyserver/caddy/releases/tag/v2.7.2
https://github.com/caddyserver/caddy/releases/tag/v2.7.1
https://github.com/caddyserver/caddy/releases/tag/v2.7.0
diff: caddyserver/caddy@v2.6.4...v2.7.3
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)