Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.spdx-tools: 0.7.1 -> 0.8.0 #248286

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Aug 10, 2023

Description of changes

https://github.com/spdx/tools-python/releases/tag/v0.8.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Aug 10, 2023

Result of nixpkgs-review pr 248286 run on x86_64-linux 1

6 packages failed to build:
  • checkov
  • checkov.dist
  • python310Packages.scancode-toolkit
  • python310Packages.scancode-toolkit.dist
  • python311Packages.scancode-toolkit
  • python311Packages.scancode-toolkit.dist
4 packages built:
  • python310Packages.spdx-tools
  • python310Packages.spdx-tools.dist
  • python311Packages.spdx-tools
  • python311Packages.spdx-tools.dist

@tobim
Copy link
Contributor Author

tobim commented Aug 10, 2023

scancode-toolkit has an open PR: aboutcode-org/scancode-toolkit#3456.
I didn't find anything for checkov.
Should we just wait?

@fabaff
Copy link
Member

fabaff commented Aug 10, 2023

checkov is released every often. I guess that it's only a matter of time to get support for spdx-tools >= 0.8.

bridgecrewio/checkov#5428

In a worth-case scenario I will override spdx-tools for checkov.

@fabaff
Copy link
Member

fabaff commented Aug 14, 2023

checkov has no support for spdx-tool>=0.8.0.

@fabaff fabaff merged commit f4c11b8 into NixOS:master Aug 14, 2023
@tobim tobim deleted the pkgs/spdx-tools-0.8 branch August 14, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants