Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libarchive: make static patch unconditional #249269

Conversation

sternenseemann
Copy link
Member

Cabal 3.8 has the same requirements as pkgsStatic even when linking dynamically, so this patch will be useful for compiling haskellPackages.libarchive.

haskell/cabal#8455

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Cabal 3.8 has the same requirements as pkgsStatic even when linking
dynamically, so this patch will be useful for compiling
haskellPackages.libarchive.

haskell/cabal#8455
@AndersonTorres
Copy link
Member

Can someone please test this on Darwin?

@AndersonTorres
Copy link
Member

AndersonTorres commented Aug 17, 2023

@ofborg build pkgsStatic.libarchive

@AndersonTorres AndersonTorres merged commit fa8eefe into NixOS:staging Aug 17, 2023
@sternenseemann sternenseemann deleted the libarchive-static-patch-unconditional branch August 18, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants