Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clubhouse-cli: use buildNpmPackage #249990

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

dotlambda
Copy link
Member

Description of changes

See #229475

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @tobim who originally packaged it in #77705

@dotlambda dotlambda merged commit 39120a6 into NixOS:master Sep 9, 2023
8 checks passed
@dotlambda dotlambda deleted the clubhouse-cli-buildNpmPackage branch September 9, 2023 22:24
ryantm pushed a commit to ryantm/nixpkgs that referenced this pull request Sep 10, 2023
…Package

clubhouse-cli: use buildNpmPackage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Re-packaged
Development

Successfully merging this pull request may close these issues.

1 participant