cockroachdb-bin: 23.1.7 -> 23.1.8

[ankhers]

Description of changes

Update cockroachdb-bin to 23.1.8 and add support for darwin.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[ankhers]

Note that I do not actually have a Darwin machine to test this on. So I am going to need to rely on others.

[neosimsim]

@ofborg build cockroachdb-bin

[neosimsim]

The update part looks good to me. However the this will not work on darwin because buildFHSEnv is not supported on darwin IIRC.

[neosimsim]

@ofborg build cockroachdb-bin

I still don't know how to build unfree packages with ofborg.

[domenkozar]

We'll probably need to package from source to support darwin, maybe the packaging got easier?

[ankhers]

We'll probably need to package from source to support darwin, maybe the packaging got easier?

#152626 (comment)

I tried updating the cockroachdb package 2 times I think. This comment explains some of the difficulties surrounding building from source.

[ankhers]

I just removed the darwin addition for now.

[wegank]

Done in #285899.