-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.python-ndn: 0.3-3 -> 0.4.1 #251985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
Aug 28, 2023
NetaliDev
reviewed
Aug 28, 2023
Janik-Haag
force-pushed
the
python-ndn
branch
2 times, most recently
from
August 29, 2023 10:45
6891e28
to
cbc349c
Compare
Result of 4 packages failed to build:
|
This PR depends on #252178 |
Janik-Haag
force-pushed
the
python-ndn
branch
from
September 25, 2023 10:28
cbc349c
to
8223c96
Compare
Result of 2 packages failed to build:
2 packages built:
Error log:error: builder for '/nix/store/fkxmmnykpmq0v1kwka4vi5axwwxkq5b1-python3.10-python-ndn-0.4.1.drv' failed with exit code 1; last 10 log lines: > node = node.children.get(step) > if node is None: > > raise KeyError(key) > E KeyError: [bytearray(b'\x08\x03not'), bytearray(b'\x08\timportant')] > > /nix/store/v6bviclbwjvz25n0glbciv09vg7gkwlb-python3.10-pygtrie-2.5.0/lib/python3.10/site-packages/pygtrie.py:630: KeyError > =========================== short test summary info ============================ > FAILED tests/integration/app_v2_test.py::TestDataValidationFalure::test_main - KeyError: [bytearray(b'\x08\x03not'), bytearray(b'\x08\timportant')] > ======================== 1 failed, 116 passed in 35.51s ======================== > /nix/store/vr6wwdxkmyy44sg0gwxi10b8fc5zhwz0-stdenv-linux/setup: line 1596: pop_var_context: head of shell_variables not a function context For full logs, run 'nix log /nix/store/fkxmmnykpmq0v1kwka4vi5axwwxkq5b1-python3.10-python-ndn-0.4.1.drv'. error: 1 dependencies of derivation '/nix/store/1a1m57myqxxbl1zw8sc025s7qycfvrdf-review-shell.drv' failed to build |
Janik-Haag
force-pushed
the
python-ndn
branch
from
September 25, 2023 13:52
8223c96
to
36d49df
Compare
Ah thanks I missed that py3.10 got broken, fixed it. |
Result of 2 packages built:
|
fabaff
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: python
8.has: clean-up
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff: named-data/python-ndn@v0.3-3...v0.4.1
Changelog: https://github.com/named-data/python-ndn/blob/v0.4.1/CHANGELOG.rst
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)