Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.python-ndn: 0.3-3 -> 0.4.1 #251985

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

Janik-Haag
Copy link
Member

Diff: named-data/python-ndn@v0.3-3...v0.4.1

Changelog: https://github.com/named-data/python-ndn/blob/v0.4.1/CHANGELOG.rst

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Janik-Haag Janik-Haag requested a review from NetaliDev August 28, 2023 15:21
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 28, 2023
@Janik-Haag Janik-Haag force-pushed the python-ndn branch 2 times, most recently from 6891e28 to cbc349c Compare August 29, 2023 10:45
@gepbird
Copy link
Contributor

gepbird commented Aug 29, 2023

Result of nixpkgs-review pr 251985 run on x86_64-linux 1

4 packages failed to build:
  • python310Packages.python-ndn
  • python310Packages.python-ndn.dist
  • python311Packages.python-ndn
  • python311Packages.python-ndn.dist

@gepbird
Copy link
Contributor

gepbird commented Aug 29, 2023

       > ERROR Missing dependencies:
       >      poetry-dynamic-versioning>=0.22.0

This PR depends on #252178

@gepbird
Copy link
Contributor

gepbird commented Sep 25, 2023

Result of nixpkgs-review pr 251985 run on x86_64-linux 1

2 packages failed to build:
  • python310Packages.python-ndn
  • python310Packages.python-ndn.dist
2 packages built:
  • python311Packages.python-ndn
  • python311Packages.python-ndn.dist
Error log:
error: builder for '/nix/store/fkxmmnykpmq0v1kwka4vi5axwwxkq5b1-python3.10-python-ndn-0.4.1.drv' failed with exit code 1;
       last 10 log lines:
       >             node = node.children.get(step)
       >             if node is None:
       > >               raise KeyError(key)
       > E               KeyError: [bytearray(b'\x08\x03not'), bytearray(b'\x08\timportant')]
       >
       > /nix/store/v6bviclbwjvz25n0glbciv09vg7gkwlb-python3.10-pygtrie-2.5.0/lib/python3.10/site-packages/pygtrie.py:630: KeyError
       > =========================== short test summary info ============================
       > FAILED tests/integration/app_v2_test.py::TestDataValidationFalure::test_main - KeyError: [bytearray(b'\x08\x03not'), bytearray(b'\x08\timportant')]
       > ======================== 1 failed, 116 passed in 35.51s ========================
       > /nix/store/vr6wwdxkmyy44sg0gwxi10b8fc5zhwz0-stdenv-linux/setup: line 1596: pop_var_context: head of shell_variables not a function context
       For full logs, run 'nix log /nix/store/fkxmmnykpmq0v1kwka4vi5axwwxkq5b1-python3.10-python-ndn-0.4.1.drv'.
error: 1 dependencies of derivation '/nix/store/1a1m57myqxxbl1zw8sc025s7qycfvrdf-review-shell.drv' failed to build

@Janik-Haag
Copy link
Member Author

Ah thanks I missed that py3.10 got broken, fixed it.

@fabaff
Copy link
Member

fabaff commented Oct 2, 2023

Result of nixpkgs-review pr 251985 run on x86_64-linux 1

2 packages built:
  • python311Packages.python-ndn
  • python311Packages.python-ndn.dist

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit a08e6c2 into NixOS:master Oct 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants