Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mainProgram to xorg.xrandr #252058

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Add mainProgram to xorg.xrandr #252058

merged 1 commit into from
Aug 29, 2023

Conversation

Fryuni
Copy link
Contributor

@Fryuni Fryuni commented Aug 29, 2023

Description of changes

Fix warning described in #249169 (comment)

trace: warning: getExe: Package "xrandr-1.5.2" does not have the meta.mainProgram attribute. We'll assume that the main program has the same name for now, but this behavior is deprecated, because it leads to surprising errors when the assumption does not hold. If the package has a main program, please set `meta.mainProgram` in its definition to make this warning go away. Otherwise, if the package does not have a main program, or if you don't control its definition, use getExe' to specify the name to the program, such as lib.getExe' foo "bar".

Things done

Added "xrandr" as the main program name for xorg.xrandr.

As mentioned on #219567 (comment) I think this serves as a workaround to remove the warning that is suddenly appearing for (to my understanding) any user using an xorg-based desktop environment that updated after #246386. But IMHO, the name of the executable should be included in this generated file

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Aug 29, 2023
Copy link
Member

@Artturin Artturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the executable is not easily known during the generation script (didnt check, just assuming) so overrides are needed

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 29, 2023
Copy link
Member

@nagy nagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you follow the guidelines for the commit message at https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions ?

@Fryuni
Copy link
Contributor Author

Fryuni commented Aug 29, 2023

Sorry, I'm used to PRs getting squashed so the messages are not that important. Fixing it.

@Fryuni
Copy link
Contributor Author

Fryuni commented Aug 29, 2023

Ok, I clearly did something wrong when rebasing

@Fryuni
Copy link
Contributor Author

Fryuni commented Aug 29, 2023

Fixed, sorry for all the pings that happened to code owners because of that.

@Artturin Artturin merged commit cbb59a1 into NixOS:master Aug 29, 2023
@Fryuni Fryuni deleted the patch-2 branch October 24, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants