-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mainProgram to xorg.xrandr
#252058
Add mainProgram to xorg.xrandr
#252058
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the executable is not easily known during the generation script (didnt check, just assuming) so overrides are needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can you follow the guidelines for the commit message at https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions ?
Sorry, I'm used to PRs getting squashed so the messages are not that important. Fixing it. |
Ok, I clearly did something wrong when rebasing |
Fix warning described in NixOS#249169
Fixed, sorry for all the pings that happened to code owners because of that. |
Description of changes
Fix warning described in #249169 (comment)
Things done
Added
"xrandr"
as the main program name forxorg.xrandr
.As mentioned on #219567 (comment) I think this serves as a workaround to remove the warning that is suddenly appearing for (to my understanding) any user using an xorg-based desktop environment that updated after #246386. But IMHO, the name of the executable should be included in this generated file