Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.heudiconv: patch out versioningit build dependency #252264

Closed
wants to merge 1 commit into from
Closed

python310Packages.heudiconv: patch out versioningit build dependency #252264

wants to merge 1 commit into from

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 30, 2023

Description of changes

Fix the build after #248866 by patching out the versioningit build dependency. The package builds without it (it has a fallback in setup.py) and it's pinned to an old version of versioningit.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@gepbird
Copy link
Contributor

gepbird commented Aug 30, 2023

Result of nixpkgs-review pr 252264 run on x86_64-linux 1

4 packages built:
  • python310Packages.heudiconv
  • python310Packages.heudiconv.dist
  • python311Packages.heudiconv
  • python311Packages.heudiconv.dist

@wegank
Copy link
Member

wegank commented Sep 5, 2023

Closed by #252799.

@wegank wegank closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants