Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dae,nixos/dae: 0.2.4 -> 0.3.0 #252978

Merged
merged 5 commits into from
Sep 5, 2023
Merged

dae,nixos/dae: 0.2.4 -> 0.3.0 #252978

merged 5 commits into from
Sep 5, 2023

Conversation

oluceps
Copy link
Member

@oluceps oluceps commented Sep 2, 2023 •
edited
Loading

Description of changes

diff: daeuniverse/dae@v0.2.4...v0.3.0

Sync nixos module from https://github.com/daeuniverse/flake.nix .

Picked a commit from pr #251161 since the option exists on upstream.
Mentioning @zzzsyyy

Removed the wrapProgram to avoid potential performance cost. Dependencies added in the module by default, and a option for user to easy specify assets.

daeuniverse/flake.nix#11

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 2, 2023
@ofborg ofborg bot requested a review from pokon548 September 2, 2023 17:36
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 2, 2023
@oluceps oluceps force-pushed the dae-upup branch 3 times, most recently from 7531ea6 to d8a827b Compare September 2, 2023 18:26
oluceps and others added 2 commits September 3, 2023 02:48
pokon548
pokon548 approved these changes Sep 3, 2023
View reviewed changes
Copy link
Contributor

@pokon548 pokon548 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great for me 💯

@oluceps oluceps requested a review from NickCao September 3, 2023 02:01
@oluceps @zzzsyyy
nixos/dae: add example link
ec0755d 
Co-authored-by: Mathias Zhang <me@zzzsy.top>
@ofborg ofborg bot requested a review from pokon548 September 3, 2023 04:17
@ofborg ofborg bot requested a review from pokon548 September 3, 2023 05:38
@luochen1990
Copy link
Contributor

LGTM.

@oluceps oluceps added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Sep 3, 2023
@oluceps oluceps changed the title dae: 0.2.4 -> 0.3.0 with module updates dae,nixos/dae: 0.2.4 -> 0.3.0 Sep 4, 2023
@oluceps oluceps mentioned this pull request Sep 5, 2023
Merged
@wegank wegank merged commit cfb6143 into NixOS:master Sep 5, 2023
11 checks passed
@oluceps oluceps deleted the dae-upup branch September 5, 2023 23:06
@gador gador mentioned this pull request Aug 6, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokon548 pokon548 pokon548 approved these changes

@zzzsyyy zzzsyyy zzzsyyy approved these changes

@NickCao NickCao Awaiting requested review from NickCao

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oluceps @luochen1990 @zzzsyyy @pokon548 @wegank