Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pandas: disable unreliable tests #253040

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

reckenrode
Copy link
Contributor

Description of changes

test_rolling.py is unreliable on aarch64-darwin depending on the compiler used and possibly optimization settings. Disabling these tests allows clang 16 to build Pandas on Darwin successfully.

See pandas-dev/pandas#38921.

Testing was done by successfully running Pandas’s check phase.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

test_rolling.py is unreliable on aarch64-darwin depending on the
compiler used and possibly optimization settings. Disabling these tests
allows clang 16 to build Pandas on Darwin successfully.

See pandas-dev/pandas#38921.
@ofborg ofborg bot requested review from FRidh, knedlsepp and 7c6f434c September 3, 2023 03:51
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 3, 2023
@marsam marsam merged commit 39c808d into NixOS:master Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants