Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jack2: fix build on Darwin #253726

Merged
merged 1 commit into from
Sep 6, 2023
Merged

jack2: fix build on Darwin #253726

merged 1 commit into from
Sep 6, 2023

Conversation

reckenrode
Copy link
Contributor

Description of changes

jack_control requires dbus, which isn’t enabled on Darwin.

I tested playback with Timidity connected to jackd.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

jack_control requires dbus, which isn’t enabled on Darwin.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 6, 2023
@ofborg ofborg bot requested a review from cillianderoiste September 6, 2023 22:46
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 6, 2023
@wegank
Copy link
Member

wegank commented Sep 6, 2023

Result of nixpkgs-review pr 253726 run on aarch64-darwin 1

4 packages marked as broken and skipped:
  • aj-snapshot
  • faust2jack
  • faust2jaqt
  • giada
1 package failed to build:
  • koboredux
6 packages built:
  • audiality2
  • jack2
  • jack2.dev
  • koboredux-free
  • ltc-tools
  • soundtracker

@wegank
Copy link
Member

wegank commented Sep 6, 2023

Result of nixpkgs-review pr 253726 run on x86_64-darwin 1

4 packages marked as broken and skipped:
  • aj-snapshot
  • faust2jack
  • faust2jaqt
  • giada
1 package failed to build:
  • koboredux
6 packages built:
  • audiality2
  • jack2
  • jack2.dev
  • koboredux-free
  • ltc-tools
  • soundtracker

@wegank wegank merged commit 1d9eef8 into NixOS:master Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants