Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mir: 2.14.1 -> 2.15.0 #255029

Merged
merged 2 commits into from
Nov 10, 2023
Merged

mir: 2.14.1 -> 2.15.0 #255029

merged 2 commits into from
Nov 10, 2023

Conversation

OPNA2608
Copy link
Contributor

Description of changes

https://github.com/MirServer/mir/releases/tag/v2.15.0

Building the documentation has been dropped from this package, as mentioned here:

I would still prefer to get these built again at some point, but this'll have to do for now.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from onny September 13, 2023 23:18
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 13, 2023
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Sep 14, 2023

@ofborg build miriway miriway.passthru.tests

@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Nov 2, 2023

@onny you co-maintain this package, could you find the time to give this a review please?

  • The bump would be nice to have in the upcoming NixOS release, at minimum it should fix an issue in Miriway where tabbing between windows can break.
  • mir and thus miriway have been broken on master for more than a week, the patch we're fetching here will fix it. Having a working Mir at release time would be nice. 🙂
  • Realistically, I doubt that I can get the docs working again soon, so I don't expect any more changes for this PR - unless another Mir version releases.

@ofborg build miriway miriway.passthru.tests

@OPNA2608 OPNA2608 mentioned this pull request Nov 3, 2023
12 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2870

@OPNA2608 OPNA2608 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 4, 2023
@OPNA2608 OPNA2608 mentioned this pull request Nov 4, 2023
13 tasks
@pbsds
Copy link
Member

pbsds commented Nov 10, 2023

Fixes https://hydra.nixos.org/build/240123241, hence part of #265948.

Result of nixpkgs-review pr 255029 run on x86_64-linux 1

3 packages built:
  • mir
  • mir.dev
  • miriway

miriway.passhtu.tests passes, and runs fine on my machine.

@pbsds pbsds merged commit 4c5b876 into NixOS:master Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants