team-list.nix: nixos-modules -> module-system

[roberth]

The module system isn't about NixOS, so for consistent messaging, I'd like to rename this.

The descriptions are conflicted about whether it's the one or the other, so I picked one. I suppose we could have two teams instead?

If some of you would like to be in a team responsible for NixOS' use of the module system, that would be great, but for consistency it should be a separate team.

@alyssais @Ericson2314 @infinisil, what do you think the scope should be? Should we do this, or do we want this team to be about NixOS instead, and de-emphasize the module system part? In that case we could have two teams.

This attribute isn't referenced explicitly anywhere - only generically at release time for the status update pings, so it's valid as a one file change.

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[infinisil]

I think it would be okay for this team to also include NixOS' use of the module system (but definitely not arbitrary NixOS modules).

[infinisil]

Suggested change

	scope = "Maintain Nixpkgs module system internals.";
	shortName = "Module system / internals";
	scope = "Maintain the Nixpkgs module system and its use in NixOS. Out of scope are NixOS modules themselves.";
	shortName = "Module system";

[roberth]

By saying "out of scope are NixOS module themselves" you've basically negated "and its use in NixOS".
Some care for callers is implied by virtue of being a library, so I don't think we need to try to describe that here, in a roundabout way.

[infinisil]

Suggested change

	scope = "Maintain Nixpkgs module system internals.";
	shortName = "Module system / internals";
	scope = "Maintain the Nixpkgs module system.";
	shortName = "Module system";

Fair enough. I think the "internal" should be removed then though, because we also maintain its surface.

[alyssais]

@alyssais @Ericson2314 @infinisil, what do you think the scope should be? Should we do this, or do we want this team to be about NixOS instead, and de-emphasize the module system part? In that case we could have two teams.

It's news to me that this team even exists, let alone that I'm on it. While you're here, could you just remove me?

[infinisil]

It's news to me that this team even exists, let alone that I'm on it.

Same actually, seems like @dasJ added this team in #165978 without an explanation how the members were decided. It seems to be used for the release blockers issues like #224457 though, and I'm fine with being listed in this team for that purpose.

done