Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: add cmakeOption and cmakeBool #256418

Merged
merged 3 commits into from
Sep 27, 2023
Merged

lib: add cmakeOption and cmakeBool #256418

merged 3 commits into from
Sep 27, 2023

Conversation

AndersonTorres
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Sep 21, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 21, 2023
@AndersonTorres
Copy link
Member Author

These vars can hold data types:

https://cmake.org/cmake/help/latest/command/set.html

It looks too gui-driven, and also too dependent on the upstream - what if this variables are truly strings that happen to act like booleans?

For now I will treat the default as STRING.

@ofborg ofborg bot requested a review from lilyinstarlight September 25, 2023 22:44
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Sep 25, 2023
Copy link
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The G'MIC derivation changes themselves look fine to me (aside from the second commit title erroneously using gmic: instead of gmic-qt: which is a minor typo), but I'll make no comment on the overall change right now

Ofborg requested my review for gmic so I figured I'd give it

@ofborg ofborg bot requested a review from lilyinstarlight September 27, 2023 15:28
@AndersonTorres AndersonTorres marked this pull request as ready for review September 27, 2023 15:47
@AndersonTorres AndersonTorres merged commit 87d05ed into NixOS:master Sep 27, 2023
@AndersonTorres AndersonTorres deleted the cmake-option branch October 16, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants