Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share-preview: init at 0.3.0 #256453

Closed
wants to merge 1 commit into from

Conversation

raboof
Copy link
Member

@raboof raboof commented Sep 21, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@raboof raboof marked this pull request as ready for review September 21, 2023 07:55
@gaykitty gaykitty mentioned this pull request Dec 25, 2023
31 tasks
@gaykitty
Copy link
Contributor

Result of nixpkgs-review pr 256453 run on x86_64-linux 1

1 package built:
  • share-preview

@raboof
Copy link
Member Author

raboof commented Dec 25, 2023

On second thought this seems very niche, so a flake outside of nixpkgs might make more sense? WDYT?

@gaykitty
Copy link
Contributor

Personally I want to see all of the Gnome Circle apps, including this one in nixpkgs.

@raboof
Copy link
Member Author

raboof commented Dec 25, 2023

OK, I'm not against it, feel free to add yourself as maintainer because I might drop it if it becomes cumbersome :)

@gaykitty
Copy link
Contributor

You can add me to the list in the nix file if you want.

@raboof raboof force-pushed the share-preview-init-at-0.3.0 branch from bdd24c0 to c165a10 Compare February 20, 2024 22:47
@raboof
Copy link
Member Author

raboof commented Feb 20, 2024

You can add me to the list in the nix file if you want.

updated!

@ofborg ofborg bot requested a review from gaykitty February 20, 2024 23:31
homepage = "https://github.com/rafaelmardojai/share-preview";
license = licenses.gpl3Only;
maintainers = with maintainers; [ gaykitty ];
platforms = platforms.all;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainProgram is always needed now, despite being the same with pname.

pkg-config
meson
glib
gtk4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gtk4
wrapGAppsHook4

gdk-pixbuf
gtk4
libadwaita
wrapGAppsHook
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wrapGAppsHook

hash = "sha256-CsnWQxE2r+uWwuEzHpY/lpWS5i8OXvhRKvy2HzqnQ5U=";
};

buildPhase = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be needed

@Aleksanaa Aleksanaa added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 30, 2024
@Aleksanaa Aleksanaa mentioned this pull request May 22, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants