Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghdl: 2.0.0 -> 3.0.0; add meta.mainProgram and other cleanup #256849

Merged
merged 3 commits into from
Sep 23, 2023
Merged

ghdl: 2.0.0 -> 3.0.0; add meta.mainProgram and other cleanup #256849

merged 3 commits into from
Sep 23, 2023

Conversation

eclairevoyant
Copy link
Contributor

@eclairevoyant eclairevoyant commented Sep 23, 2023 •
edited
Loading

Description of changes

Fixes #255462

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Lucus16 and thoughtpolice September 23, 2023 09:10
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 23, 2023
Lucus16
Lucus16 approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@Lucus16 Lucus16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@eclairevoyant eclairevoyant added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 23, 2023
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Sep 23, 2023
@bjornfor
Copy link
Contributor

Result of nixpkgs-review pr 256849 run on x86_64-linux 1

11 packages built:
  • ghdl (ghdl-mcode)
  • ghdl-llvm
  • python310Packages.cocotb
  • python310Packages.cocotb.dist
  • python310Packages.myhdl
  • python310Packages.myhdl.dist
  • python311Packages.cocotb
  • python311Packages.cocotb.dist
  • python311Packages.myhdl
  • python311Packages.myhdl.dist
  • yosys-ghdl

@bjornfor
Copy link
Contributor

I ran a small test bench with it. Worked.

Thanks!

@bjornfor bjornfor merged commit cfb7177 into NixOS:master Sep 23, 2023
@eclairevoyant eclairevoyant deleted the ghdl branch September 23, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lucus16 Lucus16 Lucus16 approved these changes

@bjornfor bjornfor bjornfor approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: ghdl 2.0 → 3.0
4 participants
@eclairevoyant @bjornfor @Lucus16 @delroth