Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave: 1.58.129 -> 1.58.135 #258060

Merged
merged 1 commit into from
Sep 30, 2023
Merged

brave: 1.58.129 -> 1.58.135 #258060

merged 1 commit into from
Sep 30, 2023

Conversation

buckley310
Copy link
Contributor

https://community.brave.com/t/release-channel-1-58-135/507927

Description of changes

version bump

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@buckley310 buckley310 added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-23.05 labels Sep 29, 2023
@ofborg ofborg bot requested review from uskudnik and rht September 29, 2023 17:17
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 29, 2023
@MikaelFangel
Copy link
Contributor

Result of nixpkgs-review:

1 package built:
brave

@NickCao NickCao merged commit b530747 into NixOS:master Sep 30, 2023
14 checks passed
@github-actions
Copy link
Contributor

Backport failed for release-23.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-23.05
git worktree add -d .worktree/backport-258060-to-release-23.05 origin/release-23.05
cd .worktree/backport-258060-to-release-23.05
git checkout -b backport-258060-to-release-23.05
ancref=$(git merge-base ff75cea66debc664ef1b4791e2eaa046068323c3 1d5b5b5062db1fd026ffaac22beeb688cbfa33a8)
git cherry-pick -x $ancref..1d5b5b5062db1fd026ffaac22beeb688cbfa33a8

@buckley310 buckley310 deleted the 2023-09-29-brave branch June 10, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants