atom*: drop

[SuperSandro2000]

Description of changes

https://atom.io redirects to https://github.blog/2022-06-08-sunsetting-atom/ which explicitly states No more security updates and the repo is archived since last November. This means atom is probably vulnerable to the recent libwebp and libvpx CVEs and probably more.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[MikaelFangel]

Ref to: #254798

[delroth]

ofborg-eval is unhappy due to various dependencies on atomEnv in nixpkgs.

[SuperSandro2000]

I just checked a few atomEnv usages and it mostly seems like a legacy artifact before electron was really a thing and can be completely removed in some cases.

[SuperSandro2000]

I started all touched applications and they started up properly but I never went past login screens.

[pbsds]

It would be nice to add a notice about Pulsar being the new Atom fork ;)

[SuperSandro2000]

We can write that into the error message but I don't think we can just alias it without any user action required.

But IMO people should just migrate to vscode ;)

[delroth]

Please re-order the commits to put the atomEnv removal at the end (after its usages were removed). Otherwise LGTM.

[pbsds]

Likely only me and a handful of others are affected by this. LGTM

Result of nixpkgs-review pr 258440 run on x86_64-linux 1

34 packages marked as broken and skipped:

• binance
• clockify
• electron_10
• electron_10-bin
• electron_11
• electron_11-bin
• electron_12
• electron_12-bin
• electron_13
• electron_13-bin
• electron_14
• electron_14-bin
• electron_15
• electron_15-bin
• electron_16
• electron_16-bin
• electron_17
• electron_17-bin
• electron_18
• electron_18-bin
• electron_19
• electron_19-bin
• electron_20
• electron_20-bin
• electron_21
• electron_21-bin
• electron_23
• electron_23-bin
• etcher
• hyper-haskell
• itch
• obinskit
• teleprompter
• whalebird

37 packages built:

• azuredatastudio
• bitwarden
• breitbandmessung
• deltachat-desktop
• electron-bin (electron_26-bin)
• electron-fiddle
• electron_22 (electron_22-bin)
• electron_24 (electron_24-bin)
• electron_25-bin
• feishin
• freetube
• hakuneko
• heroic
• heroic-unwrapped
• kuro
• logseq
• mattermost-desktop
• morgen
• obsidian
• pocket-casts
• pulsar
• schildichat-desktop
• schildichat-desktop-wayland
• sidequest
• simplenote
• teams-for-linux
• termius
• todoist-electron
• trilium-desktop
• vscode
• vscode-fhs
• vscode-langservers-extracted
• vscode-with-extensions
• vscodium
• vscodium-fhs
• webtorrent_desktop
• wire-desktop

[delroth]

Waiting for ofborg-eval to complete on the last version of this PR out of caution, I'll merge once that's finished.