luaPackages.middleclass: init at 4.1.1-0

[tmillr]

This is my first pr to nixpkgs! Bare with me

Description of changes

Add Lua package https://luarocks.org/modules/kikito/middleclass

Some things to note

• This is a basic, "pure lua", lib with no deps that appears to have been around awhile (and seems fairly popular).
• This lua module consists of just a single file named middleclass.lua which is located in the root of the repo. Hopefully this doesn't cause issues when used with neovim?
• I didn't implement tests/testing (checks?), not sure if this is necessary? I believe the repo does have tests and uses busted.
• Still need to run update script to generate the nix expressions? But it keeps failing on me with a different error each time. (edit: nix expression/drv was added manually, see below)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[alyssais]

@ofborg eval

[teto]

The updater is kinda tricky at the moment as you have noticed. You can generate the nix code by running luarocks-nix https://github.com/nix-community/luarocks-nix luarocks nix middleclass. It seems to fail though. I have a bunch of fixes in different related areas and I was planning to run an update of the lua package set this week so if you dont mind I can do it in your stead this week ?

[tmillr]

You can generate the nix code by running luarocks-nix https://github.com/nix-community/luarocks-nix luarocks nix middleclass. It seems to fail though.

I can actually get it to generate with that cmd (via nix shell nixpkgs#luarocks-nix -c luarocks nix middleclass):

{ luaOlder, buildLuarocksPackage, fetchurl, lua }:
buildLuarocksPackage {
  pname = "middleclass";
  version = "4.1.1-0";
  knownRockspec = (fetchurl {
    url    = "mirror://luarocks/middleclass-4.1.1-0.rockspec";
    sha256 = "10xzs48lr1dy7cx99581r956gl16px0a9gbdlfar41n19r96mhb1";
  }).outPath;
  src = fetchurl {
    url    = "https://github.com/kikito/middleclass/archive/v4.1.1.tar.gz";
    sha256 = "11ahv0b9wgqfnabv57rb7ilsvn2vcvxb1czq6faqrsqylvr5l7nh";
  };

  disabled = (luaOlder "5.1");
  propagatedBuildInputs = [ lua ];

  meta = {
    homepage = "https://github.com/kikito/middleclass";
    description = "A simple OOP library for Lua";
    license.fullName = "MIT";
  };
}

Maybe it's working for me because my local nix installation is on unstable (instead of master)?

Although it seems to have a slightly different structure compared to what the mass-updater outputs? For example, here's the previous commit affecting the Lua pkg list/csv: 895d66d

---

if you dont mind I can do it in your stead this week ?

That's totally fine by me, whatever works.

I'll include what I've got for now. It appears to build just fine and can be required in the lua repl.

This lua module consists of just a single file named middleclass.lua which is located in the root of the repo. Hopefully this doesn't cause issues when used with neovim?

[teto]

great ty. Format will get updated with #258819