Wire desktop bump #259996
Merged
Wire desktop bump #259996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build for a binary distribution like Wire Desktop is very light and having Hydra build and cache it is a bit of a waste of resources. We should follow Nixpkgs convention of not having Hydra build and therefore neither cache binary packages.
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 0
flokli
reviewed
Oct 9, 2023
pkgs/applications/networking/instant-messengers/wire-desktop/default.nix
Show resolved
Hide resolved
flokli
approved these changes
Oct 11, 2023
delroth
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Version bump for both platforms.
Added aarch64-darwin as a supported platform.
I've also added
hydraPlatforms = []to prevent Hydra from building and therefore also caching the package. This is Nixpkgs convention for binary packages since it wastes some precious resources.This bump does not but the next bump should address #258048, since a bump from Electron 22 to 26.3.0 has been merged to the dev branch
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)