Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action-validator: init at 0.5.3 #260217

Merged
merged 1 commit into from
Oct 10, 2023
Merged

action-validator: init at 0.5.3 #260217

merged 1 commit into from
Oct 10, 2023

Conversation

thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Oct 10, 2023

Description of changes

Validator for GitHub Actions YAML.

https://github.com/mpalmer/action-validator

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually LGTM.
I'll try it later at home.

@AndersonTorres
Copy link
Member

@ofborg build pkgsLLVM.action-validator

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 10, 2023
Copy link
Member

@PedroHLC PedroHLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like they don't hard-code version in the src, would be cool to patch it:

╭─pedrohlc at desktop in /home/pedrohlc/.cache/nixpkgs-review/pr-260217
╰─λ ./results/action-validator/bin/action-validator --version
action-validator 0.0.0-git

But gets my approval anyway.

@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Oct 10, 2023
@thiagokokada
Copy link
Contributor Author

thiagokokada commented Oct 10, 2023

Looks like they don't hard-code version in the src, would be cool to patch it:

Patching the Cargo.toml file to "fix" the version is causing the build to fail. I could probably fix this in some way but I think any way I fix it it will probably be really hacky.

@thiagokokada thiagokokada merged commit a2b87a4 into NixOS:master Oct 10, 2023
@thiagokokada thiagokokada deleted the action-validator-init branch October 10, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants