lib.fileset.fileFilter: init
#260265
Merged
lib.fileset.fileFilter: init
#260265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
infinisil
force-pushed
the
fileset.fileFilter
branch
2 times, most recently
from
377fbd3
to
43f5dc3
Compare
ofborg
bot
added
10.rebuild-darwin: 0
fricklerhandwerk
approved these changes
Oct 23, 2023
| type = subtree; | ||
| # To ensure forwards compatibility with more arguments being added in the future, | ||
| # adding an attribute which can't be deconstructed :) | ||
| "lib.fileset.fileFilter: The predicate function passed as the first argument must be able to handle extra attributes for future compatibility. If you're using `{ name, file }:`, use `{ name, file, ... }:` instead." = null; |
infinisil
force-pushed
the
fileset.fileFilter
branch
from
43f5dc3
to
26014ef
Compare
infinisil
force-pushed
the
fileset.fileFilter
branch
from
26014ef
to
f4e0043
Compare
roberth
approved these changes
Oct 24, 2023
| [b]=1 | ||
| [c/a]=1 | ||
| ) | ||
| # Note that union evaluates the first argument first if necessary, that's why we can use ./c/a here |
There was a problem hiding this comment.
Suggested change
| # Note that union evaluates the first argument first if necessary, that's why we can use ./c/a here | |
| # Note that union evaluates the first argument first if necessary. That's why we can use ./c/a here |
Suggested change
| # Note that union evaluates the first argument first if necessary, that's why we can use ./c/a here | |
| # Note that union evaluates the first argument first if necessary, so that's why we can use ./c/a here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is another split off from the WIP fileset combinators PR.
This adds one function:
lib.fileset.fileFilter :: (Attrs -> Bool) -> FileSet -> FileSetFilter the files from a file set based on a predicate function:
This work is sponsored by Antithesis ✨
Things done