Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron_{22,24}-bin: Mark EOL #260555

Merged
merged 1 commit into from
Oct 21, 2023
Merged

electron_{22,24}-bin: Mark EOL #260555

merged 1 commit into from
Oct 21, 2023

Conversation

yayayayaka
Copy link
Member

These became EOL since 2023-10-10

https://endoflife.date/electron

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@yayayayaka yayayayaka requested a review from yu-re-ka October 11, 2023 23:45
@MikaelFangel MikaelFangel added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 12, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 12, 2023
@MikaelFangel MikaelFangel removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 13, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 13, 2023
@yayayayaka @yu-re-ka
electron-{22,24}-bin: Mark EOL
204fb0e 
These are now EOL since 2023-10-10

https://endoflife.date/electron

Co-authored-by: Yureka <yuka@yuka.dev>
@yayayayaka yayayayaka force-pushed the electron-bin-mark-eol branch from 799ad3a to 204fb0e Compare October 13, 2023 12:28
@yayayayaka yayayayaka requested a review from yu-re-ka October 13, 2023 12:29
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 13, 2023
@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 21, 2023
@yayayayaka yayayayaka merged commit 3e84242 into NixOS:master Oct 21, 2023
6 checks passed
@yayayayaka yayayayaka deleted the electron-bin-mark-eol branch October 21, 2023 14:40
@github-actions github-actions bot mentioned this pull request Oct 21, 2023
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikaelFangel MikaelFangel MikaelFangel approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@yu-re-ka yu-re-ka Awaiting requested review from yu-re-ka

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yayayayaka @FliegendeWurst @MikaelFangel @yu-re-ka @delroth