Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qmk: add wb32 flash tool #261182

Merged
merged 4 commits into from
Oct 18, 2023
Merged

qmk: add wb32 flash tool #261182

merged 4 commits into from
Oct 18, 2023

Conversation

liketechnik
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 15, 2023
bhipple
bhipple approved these changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and volunteering to help maintain this!

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 15, 2023
@liketechnik @wegank
wb32-dfu-updater: apply suggestions from code review
c3528ad 
Co-authored-by: Weijia Wang <9713184+wegank@users.noreply.github.com>
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 18, 2023
@ofborg ofborg bot requested a review from bhipple October 18, 2023 16:46
@wegank wegank merged commit 964a525 into NixOS:master Oct 18, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank wegank left review comments

@babariviere babariviere Awaiting requested review from babariviere

@Ekleog Ekleog Awaiting requested review from Ekleog

@bhipple bhipple Awaiting requested review from bhipple

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liketechnik @bhipple @wegank @delroth