nwjs: 0.54.1 -> 0.82.0

[MikaelFangel]

Description of changes

This updates nwjs and as a noteworthy change I've added the autoPatchElfHook to the nativeBuildInputs, because of issues with running nwjs else wise. I've also run a formatter on the derivation, hence the many changes.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[MikaelFangel]

Result of nixpkgs review:

10 packages built:

betaflight-configurator emuflight-configurator gridtracker inav-configurator nwjs nwjs-sdk onlykey pinegrow pinegrow6 popcorntime

[MikaelFangel]

Program runs:

• popcorntime
• pinegrow
• pinegrow6
• emuflight-configurator
• betaflight-configurator
• inav-configurator
• gridtracker
• onlykey
• nwjs
• nwjs-sdk

[emilylange]

Please move the formatting into a separate commit, thanks!

[MikaelFangel]

@emilylange - Done (:

[ghost]

just some nits

[MikaelFangel]

just some nits

@robert-manchester - Cool, I appreciate it 😃

[ghost]

i was playing around with this. have some comments inline about just removing the patchelf and for loops in the install phase and modifying the inputs to autoPatchelfHook to get a nice rpath.

[edit] just posted the changes in a PR

[MikaelFangel]

Changes have been merged, and I've tested that programs using the library still run.

[ghost]

LGTM

[ghost]

i think makeWrapper can get removed.

[nekowinston]

Works well enough on my GNOME setup, but Wayland on Sway should probably support NIXOS_OZONE_WL.
I managed to make it work like so:

{pkgs ? import (fetchTarball "https://github.com/MikaelFangel/nixpkgs-upstream/archive/update-nwjs.tar.gz") {}}:
pkgs.nwjs.overrideAttrs (oldAttrs: {
  buildInputs =
    (oldAttrs.buildInputs or [])
    ++ [
      (pkgs.wrapGAppsHook.override {
        makeWrapper = pkgs.makeWrapper;
      })
    ];
  preFixup = ''
    gappsWrapperArgs+=(
      --add-flags "\''${NIXOS_OZONE_WL:+\''${WAYLAND_DISPLAY:+--ozone-platform-hint=auto --enable-features=WaylandWindowDecorations}}"
    )
  '';
})

Without overriding makeWrapper, I get an error like

[1207/174457.298986:ERROR:zip.cc(179)] Cannot open '/home/winston/${NIXOS_OZONE_WL:+${WAYLAND_DISPLAY:+--ozone-platform-hint=auto': FILE_ERROR_NOT_FOUND: No such file or directory (2)

I looked to Signal for a workaround.

Just using makeWrapper leads to ./result/bin/nw: error while loading shared libraries: libgobject-2.0.so.0: cannot open shared object file: No such file or directory, so I assume wrapGAppsHook is needed.

[MikaelFangel]

@nekowinston - The crash doesn't happen on Hyprland w/ wayland, but adding your suggestions makes nwjs respected by the WM. (:

[pbsds]

Result of nixpkgs-review pr 262424 run on x86_64-linux 1

10 packages built:

• betaflight-configurator
• emuflight-configurator
• gridtracker
• inav-configurator
• nwjs
• nwjs-sdk
• onlykey
• pinegrow
• pinegrow6
• popcorntime

It is a joy to review large changes when it is so cleanly divided into atomic commits, thank you. Runs fine and LGTM!

[MikaelFangel]

Thank you @pbsds (: