Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invidious: fix build with clang 16 #262660

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

reckenrode
Copy link
Contributor

Description of changes

Suppress warnings that cause build failures with newer clang versions.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Suppress warnings that cause build failures with newer clang versions.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 22, 2023
@wegank
Copy link
Member

wegank commented Oct 22, 2023

It seems to fail on Linux (so on master??), would you like to fix that?

@reckenrode
Copy link
Contributor Author

It seems to fail on Linux (so on master??), would you like to fix that?

I pushed another commit that should fix the build on Linux.

@ofborg ofborg bot added 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 23, 2023
@wegank
Copy link
Member

wegank commented Oct 23, 2023

@ofborg build invidious invidious.passthru.tests

@wegank
Copy link
Member

wegank commented Oct 24, 2023

In any case, invidious.passthru.tests already fails on master, which seems to be a regression from staging-next.

@wegank wegank merged commit 763fc7d into NixOS:master Oct 24, 2023
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants