Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal-bootstrap.bash{,_2_05}: Normalize the NIX_BUILD_CORES variable #262847

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

emilytrau
Copy link
Member

Description of changes

Fixes #262717
Related #227914

Things done

  • Built on platform(s)
    • i686-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 merged commit b67d497 into NixOS:master Oct 31, 2023
25 checks passed
@emilytrau emilytrau deleted the minimal-nix-cores branch October 31, 2023 15:09
DavidEGrayson added a commit to DavidEGrayson/nixcrpkgs that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minimal-bootstrap: handle NIX_BUILD_CORES=0
2 participants