lanzaboote-tool: init at 0.3.0 #263712
Merged
lanzaboote-tool: init at 0.3.0 #263712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 27, 2023
RaitoBezarius
force-pushed
the
lanzaboote-tool
branch
from
933bea4 to
c9389c4
Compare
ofborg
bot
added
8.has: package (new)
SuperSandro2000
approved these changes
Oct 27, 2023
delroth
added
the
12.approvals: 1
oxalica
reviewed
Oct 27, 2023
nikstur
reviewed
Oct 28, 2023
RaitoBezarius
force-pushed
the
lanzaboote-tool
branch
from
c9389c4 to
3a8254e
Compare
delroth
removed
the
12.approvals: 1
ofborg
bot
added
10.rebuild-darwin: 0
|
The tests fail on aarch64-linux. Should we just mark it as a bad platform for now to get this merged? |
That makes sense, yes. |
RaitoBezarius
force-pushed
the
lanzaboote-tool
branch
from
3a8254e to
7f4a5d1
Compare
I adopted rather an allow-list than a block-list because every other architecture won't work with lanzaboote for now. So we filter out any platform that is not known to possess UEFI for that specific variant of the lanzatool which will anyway be UEFI-only. |
nikstur
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Split of #231951 for ease of review and getting this done, as requested by reviewers.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)