Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-analyzer-unwrapped: optional proc-macro-srv-cli #263871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Oct 28, 2023

Description of changes

Resolves a crash related to rust-lang/rust-analyzer#14991

:; export RUST_ANALYZER_INTERNALS_DO_NOT_USE='this is unstable'
:; nix shell .#rust-analyzer-unwrapped -c rust-analyzer-proc-macro-srv < /dev/null

thread 'main' panicked at 'proc-macro-srv-cli requires the `sysroot-abi` feature to be enabled', crates/proc-macro-srv-cli/src/main.rs:23:5

Unfortunately, the server isn't able to compile without unstable rust so I've chosen to disable it by default since it's currently broken - though I don't personally have a preference on whether to enable or disable it by default? Another approach is to pull the macro server out into an entirely seperate package, though that may be inefficient since both binaries share common dependencies.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from oxalica October 28, 2023 00:59
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@FliegendeWurst FliegendeWurst added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants