mecab-nodic,mecab,python3Package.uamqp,source-highlight: fix build with clang 16 #265344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reckenrode
changed the title
ofborg
bot
added
10.rebuild-darwin: 101-500
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
paveloom
reviewed
Nov 4, 2023
There was a problem hiding this comment.
I suggest putting this in pkgs/tools/text/mecab/base.nix (after configureFlags), since both of these derivations (default.nix and nodic.nix) derive their attribute sets from the one in base.nix. It's the same derivation, but one is with the ipadic dictionary (default.nix), and the other one is without it (nodic.nix).
reckenrode
force-pushed
the
clang16-fixes-batch3
branch
2 times, most recently
from
d2a0297 to
7b7eacc
Compare
paveloom
approved these changes
Nov 4, 2023
wegank
reviewed
Nov 4, 2023
delroth
added
12.approvals: 1
Force the language mode to C++14. mecab-nodic uses several features that have been removed from C++17.
Add a `const` to fix an incompatible function pointer conversion error.
Fetch upstream patch to add C++17 compatibility (the default in clang 16) and standardize fetchpatch URLs and hashes.
reckenrode
force-pushed
the
clang16-fixes-batch3
branch
from
7b7eacc to
3f99aef
Compare
delroth
removed
the
12.approvals: 1
ofborg
bot
added
10.rebuild-linux: 11-100
and removed
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
labels
wegank
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Second batch of fixes for staging-next #263535.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)