Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtk: fix build with clang 16 #265665

Merged
merged 5 commits into from
Nov 6, 2023
Merged

vtk: fix build with clang 16 #265665

merged 5 commits into from
Nov 6, 2023

Conversation

wegank
Copy link
Member

@wegank wegank commented Nov 5, 2023 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from tfmoraes, knedlsepp and lheckemann November 5, 2023 15:28
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 5, 2023
@wegank
Copy link
Member Author

wegank commented Nov 5, 2023

Result of nixpkgs-review pr 265665 run on aarch64-darwin 1

25 packages marked as broken and skipped:
  • c3d
  • elmerfem
  • ezminc
  • intensity-normalization
  • intensity-normalization.dist
  • python310Packages.intensity-normalization
  • python310Packages.intensity-normalization.dist
  • python310Packages.pydicom-seg
  • python310Packages.pydicom-seg.dist
  • python310Packages.pymedio
  • python310Packages.pymedio.dist
  • python310Packages.pyradiomics
  • python310Packages.pyradiomics.dist
  • python310Packages.torchio
  • python310Packages.torchio.dist
  • python311Packages.intensity-normalization
  • python311Packages.intensity-normalization.dist
  • python311Packages.pydicom-seg
  • python311Packages.pydicom-seg.dist
  • python311Packages.pymedio
  • python311Packages.pymedio.dist
  • python311Packages.pyradiomics
  • python311Packages.pyradiomics.dist
  • python311Packages.torchio
  • python311Packages.torchio.dist
17 packages failed to build:
  • pcl
  • python310Packages.dicom2nifti
  • python310Packages.dicom2nifti.dist
  • python310Packages.gdcm
  • python310Packages.pyvista
  • python310Packages.pyvista.dist
  • python310Packages.sfepy
  • python310Packages.sfepy.dist
  • python311Packages.dicom2nifti
  • python311Packages.dicom2nifti.dist
  • python311Packages.gdcm
  • python311Packages.mayavi
  • python311Packages.mayavi.dist
  • python311Packages.pyvista
  • python311Packages.pyvista.dist
  • python311Packages.sfepy
  • python311Packages.sfepy.dist
9 packages built:
  • ants
  • f3d
  • gdcm
  • python310Packages.mayavi
  • python310Packages.mayavi.dist
  • python310Packages.vtk
  • python311Packages.vtk
  • vtk (vtk_9)
  • vtkWithQt5 (vtk_9_withQt5)

@ofborg ofborg bot requested review from anthonyroussel and ccellado November 5, 2023 23:13
@ofborg ofborg bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 5, 2023
@ofborg ofborg bot requested a review from viric November 6, 2023 00:01
@wegank
Copy link
Member Author

wegank commented Nov 6, 2023

@ofborg build python311Packages.gdcm

@wegank
Copy link
Member Author

wegank commented Nov 6, 2023

Oh, it actually fails on master, so not a regression.

@wegank wegank merged commit 9f75539 into NixOS:staging-next Nov 6, 2023
@wegank wegank deleted the vtk-clang-16 branch November 6, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfmoraes tfmoraes Awaiting requested review from tfmoraes

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

@lheckemann lheckemann Awaiting requested review from lheckemann

@anthonyroussel anthonyroussel Awaiting requested review from anthonyroussel

@ccellado ccellado Awaiting requested review from ccellado

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wegank