Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chickenPackages_4.chicken: fix build on x86_64-darwin #266162

Merged
merged 1 commit into from
Nov 9, 2023
Merged

chickenPackages_4.chicken: fix build on x86_64-darwin #266162

merged 1 commit into from
Nov 9, 2023

Conversation

reckenrode
Copy link
Contributor

Description of changes

Fixes the build of chicken 4 on staging-next #263535.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@reckenrode
chickenPackages_4.chicken: fix build on x86_64-darwin
c9575b1 
Use the `@executable_path` because the full path to the store is too long.

Also add the target prefix to `install_name_tool`.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 8, 2023
@ofborg ofborg bot requested a review from corngood November 8, 2023 01:55
@wegank
Copy link
Member

wegank commented Nov 9, 2023

Result of nixpkgs-review pr 266162 run on x86_64-darwin 1

13 packages built:
  • chickenPackages_4.chicken
  • chickenPackages_4.chickenEggs.base64
  • chickenPackages_4.chickenEggs.defstruct
  • chickenPackages_4.chickenEggs.http-client
  • chickenPackages_4.chickenEggs.intarweb
  • chickenPackages_4.chickenEggs.matchable
  • chickenPackages_4.chickenEggs.sendfile
  • chickenPackages_4.chickenEggs.simple-md5
  • chickenPackages_4.chickenEggs.uri-common
  • chickenPackages_4.chickenEggs.uri-generic
  • chickenPackages_4.egg2nix
  • ugarit
  • ugarit-manifest-maker

@wegank wegank merged commit e49468c into NixOS:staging-next Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corngood corngood Awaiting requested review from corngood

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reckenrode @wegank