Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.{crypton,SHA}: disable tests on aarch32 #266213

Closed
wants to merge 2 commits into from

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Nov 8, 2023

Description of changes

crypton and SHA are dependencies of shellcheck, which is used by writeShellApplication
Upstream issues: kazu-yamamoto/crypton#25 GaloisInc/SHA#16

Things done

  • Built on platform(s)
    • armv7l-linux (native)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@misuzu misuzu changed the title haskellPackages.SHA: disable tests on aarch32 haskellPackages.{crypton,SHA}: disable tests on aarch32 Nov 8, 2023
@cdepillabout
Copy link
Member

@misuzu Thanks for reporting this.

We're generally reluctant to disable tests for security-related Haskell libraries, at least without a confirmation from upstream.

If you could debug exactly why the tests are failing (and prove that the tests are incorrect, not the library itself) on GaloisInc/SHA#16, that would probably help get the upstream maintainer to respond faster.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 8, 2023
@misuzu
Copy link
Contributor Author

misuzu commented Nov 8, 2023

If you could debug exactly why the tests are failing (and prove that the tests are incorrect, not the library itself) on GaloisInc/SHA#16, that would probably help get the upstream maintainer to respond faster.

Sadly, I have zero knowledge on how to do that. I simply want to use virtualisation.oci-containers module (which requires shellcheck package) to start my containers on armv7l-linux hardware

@cdepillabout
Copy link
Member

@misuzu Maybe you could disable the use of shellcheck in writeShellApplication on armv7l-linux, citing this PR?

@misuzu
Copy link
Contributor Author

misuzu commented Nov 8, 2023

@misuzu Maybe you could disable the use of shellcheck in writeShellApplication on armv7l-linux, citing this PR?

#266298

@misuzu
Copy link
Contributor Author

misuzu commented Nov 8, 2023

Looks like shellcheck-minimal isn't affected, there's no need for this change

@misuzu misuzu closed this Nov 8, 2023
@misuzu misuzu deleted the haskell-sha-armv7l branch November 9, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants