Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liburing: 2.4 -> 2.5 #266276

Merged
merged 1 commit into from
Nov 9, 2023
Merged

liburing: 2.4 -> 2.5 #266276

merged 1 commit into from
Nov 9, 2023

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Nov 8, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@NickCao NickCao added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Nov 8, 2023
@ofborg ofborg bot requested a review from thoughtpolice November 8, 2023 14:52
@thoughtpolice
Copy link
Member

Should we target staging with this?

@NickCao
Copy link
Member Author

NickCao commented Nov 8, 2023

Should we target staging with this?

Sure.

@NickCao NickCao changed the base branch from master to staging November 8, 2023 16:15
thoughtpolice
thoughtpolice approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks fine to me, so we can go ahead and throw it on the pile once the CI finishes.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 8, 2023
@ofborg ofborg bot requested a review from thoughtpolice November 8, 2023 18:50
@NickCao NickCao merged commit b4df396 into NixOS:staging Nov 9, 2023
@NickCao NickCao deleted the liburing branch November 9, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickCao @thoughtpolice @delroth