webmacs: use GCC instead of clang #266668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did try to run it, but it crashes when Qt WebEngine tries to mmap ICU data. I don’t know if that’s related to my running macOS 14.1 or some other issue. Regardless, fixing Qt WebEngine is out of scope for fixing this build. |
ofborg
bot
added
10.rebuild-darwin: 0
|
PyQtWebEngine in nixpkgs has indeed always been very broken on darwin. |
|
Wait, no rebuild? |
|
The change to allow overriding the stdenv in |
|
Converting to draft until I have some time to figure out what’s happening here. |
clang fails to build webmacs due to numerous errors relating to its use of the C++ standard library.
reckenrode
force-pushed
the
webmacs-fix
branch
from
6beebe1 to
f29fed8
Compare
|
The required override isn’t on master. It’s on staging-next, so I retargeted staging-next. There should be some rebuilds now. |
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
clang fails to build webmacs due to numerous errors relating to its use of the C++ standard library.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)