pam: fix pam_unix autohentication failures when ran as user #266828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit d0c42df "pam: bind Linux-PAM locales from pam-specific folder (upstream patch)" added autoreconfHook269 into one of the postPatch phases. This clobbered the change applied by `suid-wrapper-path.patch` as it was patching Makefile.in. As a result `nixosTests.sway` test started failing as: check pass; user unknown Running `swaylock` on real system exhibited the same result. As `suid-wrapper-path.patch` is clobbered we were running non-suid version of `unix_chkpwd`: /nix/store/...-linux-pam-1.5.2/sbin/unix_chkpwd instead of SUID-wrapped /run/wrappers/bin/unix_chkpw The fix is trivial: move the patch from auto-generated file to `Makefile.am`. Discovered-by: Yureka
12 tasks
|
Note: this is a rebuild of all of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit d0c42df "pam: bind Linux-PAM locales from pam-specific folder (upstream patch)" added autoreconfHook269 into one of the postPatch phases.
This clobbered the change applied by
suid-wrapper-path.patchas it was patching Makefile.in.As a result
nixosTests.swaytest started failing as:Running
swaylockon real system exhibited the same result.As
suid-wrapper-path.patchis clobbered we were running non-suid version ofunix_chkpwd:instead of SUID-wrapped
The fix is trivial: move the patch from auto-generated file to
Makefile.am.Discovered-by: Yureka
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)