lib.fileset: Lazier path existence check
#267091
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
8.has: documentation
3 tasks
infinisil
changed the title
lib.fileset: Lazier path existence check
ofborg
bot
added
10.rebuild-darwin: 0
- Make fromSource's missing file error message more consistent with others, and add a test for it - Indent some function arguments - Make the contextual error test not rely on nested paths Makes the next commit smaller - Add single-file tests for trace and fileFilter
Allows things like `difference ./. ./a` even if `./a` doesn't exist. Not perfect however, because `difference ./. (difference ./a ./a/b)` doesn't give an error if `./a/b` doesn't exist. This is considered an edge case, but it could be fixed in the future.
infinisil
force-pushed
the
lib.fileset-lazier
branch
from
2bc6620 to
3cf0b3c
Compare
Yes, this in particular. |
|
Looks like we need a sercet breaker. |
|
There were some minor changes here useful on their own, created a separate PR for those: #268520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Allows things like
difference ./. ./aeven if./adoesn't exist.Another case that's now doable is
intersection ./a (union ./a ./b)even if./bdoesn't exist.This is an alternative to #265964 that doesn't require a new function and is more transparent to the user.
It's not perfect however, because
difference ./. (difference ./a ./a/b)doesn't give an error anymore if
./a/bdoesn't exist. We can maybe consider this an edge case. This could be fixed in the future, but would need a non-trivial change to the internal representation.More problematic however is that you aren't protected against typos in the negative argument anymore: If you want to remove
./secret, but you writedifference ./. ./sercetinstead, it would just fail silently and import the path into the store! This is making me think that we maybe shouldn't do this.This work is sponsored by Antithesis ✨
Things done