Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileset.fileFilter: Restrict second argument to paths #267384

Merged
merged 1 commit into from
Nov 15, 2023

Commits on Nov 15, 2023

  1. lib.fileset.fileFilter: Restrict second argument to paths

    While this change is backwards-incompatible, I think it's okay because:
    - The `fileFilter` function is not yet in a stable NixOS release, it was only merged about [a month ago](NixOS#257356).
      - All public uses of the function on GitHub only pass a path
    - Any `fileFilter pred fileset` can also be expressed as `intersection fileset (fileFilter pred path)` without loss of functionality.
      - This is furthermore pointed out in the new error message when a file set is passed
    infinisil committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    1c3eb9e View commit details
    Browse the repository at this point in the history